Skip to content

Ensure proper cleanup of temporary ZIP files (AST-42950) #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cx-elchanan-arbiv merged 6 commits into from
Dec 26, 2024
Merged

Ensure proper cleanup of temporary ZIP files (AST-42950) #984

cx-elchanan-arbiv merged 6 commits into from
Dec 26, 2024

Conversation

@cx-elchanan-arbiv
Copy link
Contributor

@cx-elchanan-arbiv cx-elchanan-arbiv commented Dec 24, 2024

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

https://checkmarx.atlassian.net/browse/AST-42950

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@github-actions github-actions bot added bug Something isn't working fix labels Dec 24, 2024
@github-actions
Copy link

github-actions bot commented Dec 24, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – c843a555-19b6-45f7-a9c1-85caeffd6930

No New Or Fixed Issues Found

cx-miryam-foifer
cx-miryam-foifer reviewed Dec 25, 2024
View reviewed changes
cx-daniel-greenspan
cx-daniel-greenspan reviewed Dec 26, 2024
View reviewed changes
@cx-elchanan-arbiv cx-elchanan-arbiv merged commit 2fc507b into main Dec 26, 2024
9 checks passed
@cx-elchanan-arbiv cx-elchanan-arbiv deleted the fix/elchanan/temp_zip_cleanup branch December 26, 2024 11:20
@cx-elchanan-arbiv cx-elchanan-arbiv restored the fix/elchanan/temp_zip_cleanup branch January 2, 2025 16:37
@cx-elchanan-arbiv cx-elchanan-arbiv deleted the fix/elchanan/temp_zip_cleanup branch January 2, 2025 16:43
cx-anjali-deore pushed a commit that referenced this pull request Jul 3, 2025
@cx-elchanan-arbiv
Merge pull request #984 from Checkmarx/fix/elchanan/temp_zip_cleanup
ebbe121 
Ensure proper cleanup of temporary ZIP files (AST-42950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-miryam-foifer cx-miryam-foifer cx-miryam-foifer left review comments

@cx-ben-alvo cx-ben-alvo Awaiting requested review from cx-ben-alvo

+1 more reviewer

@cx-daniel-greenspan cx-daniel-greenspan cx-daniel-greenspan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cx-elchanan-arbiv @cx-daniel-greenspan @cx-miryam-foifer